Api Muncher - Sahana Murthy - Queues#55
Conversation
API MuncherWhat We're Looking For
Your lack of test coverage is increasingly concerning to me. I know that's something we discussed on MediaRanker, and reviewing your team's bEtsy repository I only see one test file where you made any commits at all. All of that combined with the fact that you haven't written a single test for this project indicates the importance of testing hasn't sunk in. Testing is an absolutely essential part of programming. It allows you to catch problems early, and many studies have shown that strong test-driven development reduces both time to market and the number and severity of bugs that make it to customers. Moreover, because writing tests forces you to think through all the possible states and interactions of your code, it is a strong learning tool and an important part of the way we teach software at Ada. It would definitely be worthwhile for you to spend some time with a tutor to reinforce this skill - let's talk about this in person next week. Other than that, this project looks really good - you've hit all the functionality and crafted a solid, easy to use UI. Good work! |
|
|
||
| url = "#{RECIPE_URI}#{param}" | ||
| recipe = HTTParty.get(url, query: query_params) | ||
| return recipe |
There was a problem hiding this comment.
It's interesting to me that above you return ApiRecipe objects, but here you return the results directly. Seems to me you could add a little bit of functionality to ApiRecipe and be able to reuse it nicely.
2 participants
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions